I was coding calmly this evening, classical cycle :
- test => fail to build
- code so that it builds
- fail the test => code so that it passes the test
Here is my model :
public class BlogPostComment : ModelBase
{
[Required(ErrorMessageResourceType = typeof(ErrorStrings), ErrorMessageResourceName = "Required")]
public string CommenterName { get; set; }
[Required(ErrorMessageResourceType = typeof(ErrorStrings), ErrorMessageResourceName = "Required")]
[EmailAddress(ErrorMessageResourceType = typeof(ErrorStrings), ErrorMessageResourceName = "InvalidEmail")]
[DataType(DataType.EmailAddress)]
public string CommenterEmail { get; set; }
public string CommenterCountry { get; set; }
public string CommenterWebSite { get; set; }
[Required(ErrorMessageResourceType = typeof(ErrorStrings), ErrorMessageResourceName = "Required")]
public string Content { get; set; }
[ForeignKey("BlogPost")]
public long PostId { get; set; }
public virtual BlogPost BlogPost {get;set;}
}I wrote two simple unit tests to test the validation logic in my model
[Test]
[ExpectedException(typeof(ValidationException), ExpectedMessage="The field [Email] is required!")]
public void EmailIsRequired()
{
var blogPostComment = new BlogPostComment{CommenterEmail =string.Empty,Content ="testing", CommenterName ="Mechanical"};
Asert.IsTrue(blogPostComment.IsValid());
}
[Test]
[ExpectedException(typeof(ValidationException), ExpectedMessage="The field [Email] is invalid!")]
public void TestInvalidEmail()
{
var blogPostComment = new BlogPostComment{CommenterEmail ="mechanical",Content ="testing", CommenterName ="Mechanical"};
Asert.IsTrue(blogPostComment.IsValid());
}That seemed fair to me, I hit the build which was green and re-run the tests and surprise
I got a message saying :
After a quick search, I found these :
Posted by Microsoft on 9/18/2012 at 11:02 AM This is a known issue with the new data annotation attributes added in .NET 4.5. To workaround it, explicitly set the ErrorMessage »property of the attribute to null
After having modified the code,
{
....
[Required(ErrorMessageResourceType = typeof(ErrorStrings), ErrorMessageResourceName = "Required", ErrorMessage = null)]
[EmailAddress(ErrorMessageResourceType = typeof(ErrorStrings), ErrorMessageResourceName = "InvalidEmail", ErrorMessage = null)]
[DataType(DataType.EmailAddress)]
public string CommenterEmail { get; set; }
...
}All was in order.